fix(h3): drop trainer-side LoRA collector; keep PEFT names on IPC - #226
Merged
Merged
Conversation
sglang-d lora_merge now maps PEFT/diffusers names and applies the FFN swap, so H3 no longer needs a dedicated IPC grouper.
niehen6174
requested review from
Rockdu,
guapisolo and
zhihengy
as code owners
September 1, 2026 05:18
Rockdu
added
run-ci-e2e
Collaborator
|
will merge after sgl-project/sglang#37350 is merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
h3_weight_key_mapperand the H3 LoRA IPC grouper.transformer_blocks.*.attn.to_q,ff.net.0.proj, …).lora_mergemaps those names and applies the disk-load FFN swap.--use-lora --lora-ipc-weight-sync(SFT /--train-onlyunchanged).Depends on the matching sglang-d change on
sglang-miles-h3.ci-sglang-pr: #37350
Test plan
pytest tests/fast/backends/fsdp_utils/test_peft_lora_key_mapper.py